Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

코드리뷰 봇 구현 #18

Merged
merged 10 commits into from
Apr 2, 2024
Merged

코드리뷰 봇 구현 #18

merged 10 commits into from
Apr 2, 2024

Conversation

JUDONGHYEOK
Copy link
Collaborator

코드리뷰 봇을 구현하는 작업입니다.

상세내용: #17

@JUDONGHYEOK JUDONGHYEOK requested a review from 2yunseong March 30, 2024 07:02
@JUDONGHYEOK JUDONGHYEOK self-assigned this Mar 30, 2024
@JUDONGHYEOK JUDONGHYEOK reopened this Mar 30, 2024
Copy link
Collaborator

@2yunseong 2yunseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~! 두 가지 의견 확인 부탁드립니다 !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
윈도우에서 확인해보니 invaild 한 문자가 들어가 있어, 혹시 변경 가능하실까요?

\b 문자가 들어가 있는걸로 보이네욥

image

Comment on lines +96 to +97
if (github.context.payload.pull_request.requested_reviewers.length > 0)
send();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 부분에 리뷰어 분들도 리뷰 제출 시 알람 갈 수 있도록 제가 한번 기능추가 해봐도 괜찮을까요??

찾아보니 pull_request_review 웹훅 보니

pull_request_review 이벤트에서 github.event.review.state 를 적절히 짬뽕하면 될 것 같은 생각이 드네용

Github Action 예시

@geongyu09 geongyu09 merged commit 6f5bcc6 into main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants